-
So at some point, third-level markdown headings (that would render to h3 tags) started rendering as extremely small (smaller than h6). And it's only h3. The others (h1,h2,h4,h5,h6) all render at normal sizes. When I invoke the print preview, bring up chrome dev tools, elements tab, select an h3, and look at styles, I see this: When I de-select the font-size line, things are back to normal. Chrome dev-tools shows a filename as settings.css.
I looked in the GitHub repo for vsc-print, and the settings.css I found is apparently not the same one. So I'm lost as to ...
If this turns out to be a legitimate issue, I can open one, but I thought I'd go the discussion route first. |
Beta Was this translation helpful? Give feedback.
Replies: 10 comments 2 replies
-
That file is bundled. You should be able to override it using a stylesheet of your own but I'll verify that before calling it advice |
Beta Was this translation helpful? Give feedback.
-
I just re-read your post
It's not the same because it's partly generated from your VS Code settings. Which is why it's called A better question is why the settings file is being delivered for Markdown. It mostly applies to printing source code, not Markdown. This may be a consequence of my adding support for syntax colouring of source code in Markdown fenced blocks. |
Beta Was this translation helpful? Give feedback.
-
I appreciate your patience. At the moment my life is full of property sale prep and caring for my mum. |
Beta Was this translation helpful? Give feedback.
-
I've begun to investigate this and here's how it looks on my system. Now, you may recall me writing that The font size has changed but the size is not what I expected. So we have both a bug and a design issue. The bug is that the size isn't being correctly picked up, and the design issue is that the settings resource shouldn't be used at all by Markdown pages. |
Beta Was this translation helpful? Give feedback.
-
I tried adding a css file but the link occurs before the link to the settings so it failed to override even when I added I will see about suppressing inclusion of the settings link for Markdown but this may have consequences for the styling of source code in fenced blocks. |
Beta Was this translation helpful? Give feedback.
-
I was wondering why I would set h3 in settings. Git blame reveals this change came in with a PR a year ago, and why. When you print a group of files you can have the filepath shown as an h3 heading at the start of each file. This was to slave the heading size to the listing text. I'm modifying the class to |
Beta Was this translation helpful? Give feedback.
-
And the answer is Print has its own setting for that. Blame says it was me but nobody can prove that! |
Beta Was this translation helpful? Give feedback.
-
Looking better. |
Beta Was this translation helpful? Give feedback.
-
Update your extension to 0.13.3 and let me know whether it's truly resolved by closing the issue or giving more details. |
Beta Was this translation helpful? Give feedback.
-
Yes, 0.13.3 works. The last previous version that did not have the issue was 0.11.28, it seemed to start happening with 0.12.x. Thanks! |
Beta Was this translation helpful? Give feedback.
Yes, 0.13.3 works. The last previous version that did not have the issue was 0.11.28, it seemed to start happening with 0.12.x. Thanks!