Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP tests don't work #17

Open
ArtjomP opened this issue Jan 3, 2018 · 6 comments
Open

UWP tests don't work #17

ArtjomP opened this issue Jan 3, 2018 · 6 comments
Assignees
Milestone

Comments

@ArtjomP
Copy link
Collaborator

ArtjomP commented Jan 3, 2018

Hi there!
It seems that NUnit doesn't support UWP tests.
Do you mind if I change UWP tests from NUnit to MS test?
It will require some conditional variables for every test. Something like this:
#ifdef UWP [TestMethod] #else [Test] #endif

Or am I wrong and UWP tests actually work well?
May be any other ideas.

@Aragas
Copy link
Member

Aragas commented Jan 11, 2018

Sorry for the long answer. Yes, feel free to do it

ArtjomP added a commit to ArtjomP/PCLExt.FileStorage that referenced this issue Feb 7, 2018
Aragas pushed a commit that referenced this issue Feb 15, 2018
…se for UWP only MSTests work well. Fixing issue #17 (#18)
@Aragas Aragas added this to the Fix UWP milestone Jun 22, 2018
@Aragas
Copy link
Member

Aragas commented Jun 26, 2018

I just tried the tests without any modification, they fail, well, they are left pending. Hope you'll be able to fix it.
And by the way, you can convert those Action func = () => { ... } to a local function
EDIT:
Actually, it was on Release configuration. It fails
DEP3000: Attempts to stop the application failed. This may cause the deployment to fail. [0x92330047] HRESULT: 0x92330047 PCLExt.FileStorage.UWP.Test

@ArtjomP
Copy link
Collaborator Author

ArtjomP commented Jun 26, 2018

Ok, I'll check it asap. I believe it will be this week. As far as I remember they worked well.

@ArtjomP
Copy link
Collaborator Author

ArtjomP commented Jun 26, 2018

Hi again @Aragas.

  1. I took the latest version from the master branch (my merge commit):
  2. Run all the tests & they work well screenshot.

The issue may be if you launch tests in configuration "Any CPU". You need to select configuration x86 or x64 for running UWP tests because a UWP project can't be platform independent & should be compiled into native instructions. Prove.

@Aragas
Copy link
Member

Aragas commented Jun 26, 2018

@ArtjomP well, I'm not sure on the issue
I just need to select the UWP platform and it should work, no additional components to install?
It's on my side, because your fork doesn't work either
It's this issue https://developercommunity.visualstudio.com/content/problem/249594/cant-run-unit-universal-unit-test.html

@Aragas
Copy link
Member

Aragas commented Jun 26, 2018

Anyway, the tests work, so everything should be fine. After you'll check those issues and give a green light, I'll release 1.4.1 with UWP

Aragas pushed a commit that referenced this issue Jun 30, 2018
* UWP unit tests framework has been changed from NUnit to MSTest. Because for UWP only MSTests work well. Fixing issue #17

* Tests added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants