Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip may be empty when using locale other than english #181

Open
ockam opened this issue Sep 24, 2015 · 1 comment
Open

Tooltip may be empty when using locale other than english #181

ockam opened this issue Sep 24, 2015 · 1 comment

Comments

@ockam
Copy link

ockam commented Sep 24, 2015

When using the french locale, the tooltip that appears over then pencil icon when hovering an editable allows show an empty tooltip.

Worked around with:

ToolTipPlugin.prototype.init = function() {
    this.raptor.bind('layoutReady', function(node) {
        $(node)
            .on('mouseover', '[title]', function(event) {
                if ($(this).attr('title')) {
                    $(this)
                        .attr('data-title', $(this).attr('title'))
                        .removeAttr('title');
                }
            });
    });
};
@deeknow
Copy link

deeknow commented Dec 8, 2015

Hey @ockam thanks for posting the attr check above. Could you please consider sending a pull request for this patch to tool-tip.js so we can credit you. Before doing so please also read: https://www.raptor-editor.com/contributing

In the mean time I've committed a related fix to the raptor-locales project for the languages other than French that had an empty string "" value instead of null for the clickButtonToEditTitle string. When these values are null the original tool-tip code removes the blank title attribute you were seeing. See: PANmedia/raptor-locales@7b9626e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants