From e13772a3c079e2d4581044b525a43b9587f73586 Mon Sep 17 00:00:00 2001 From: Ryan Mullins Date: Thu, 12 Sep 2024 06:08:42 -0700 Subject: [PATCH] LIT: Use `ENV VAR=value` form in Dockerfiles PiperOrigin-RevId: 673814234 --- Dockerfile | 4 ++-- lit_nlp/examples/vertexai/Dockerfile | 11 +++++------ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/Dockerfile b/Dockerfile index 11c1eeea..4dcf08ad 100644 --- a/Dockerfile +++ b/Dockerfile @@ -27,7 +27,7 @@ RUN echo "deb https://dl.yarnpkg.com/debian/ stable main" | \ RUN apt update && apt -y install yarn # Copy local code to the container image. -ENV APP_HOME /app +ENV APP_HOME=/app WORKDIR $APP_HOME # Set up python environment with production dependencies @@ -40,7 +40,7 @@ COPY . ./ # Build front-end with yarn WORKDIR $APP_HOME/lit_nlp/client -ENV NODE_OPTIONS "--openssl-legacy-provider" +ENV NODE_OPTIONS="--openssl-legacy-provider" RUN yarn && yarn build && rm -rf node_modules/* # Run LIT server diff --git a/lit_nlp/examples/vertexai/Dockerfile b/lit_nlp/examples/vertexai/Dockerfile index 04244d1d..03c7828c 100644 --- a/lit_nlp/examples/vertexai/Dockerfile +++ b/lit_nlp/examples/vertexai/Dockerfile @@ -26,7 +26,7 @@ RUN apt-get update RUN apt-get install -y wget curl gnupg2 gcc g++ git # Copy local code to the container image. -ENV APP_HOME /app +ENV APP_HOME=/app WORKDIR $APP_HOME COPY ./lit_nlp/examples/vertexai/gunicorn_config.py ./ @@ -57,9 +57,8 @@ RUN apt update && apt -y install yarn # Set up python environment with production dependencies # This step is slow as it installs many packages. COPY requirements_core.txt ./ -RUN python -m pip install -r requirements_core.txt - -COPY lit_nlp/examples/vertexai/requirements.txt lit_nlp/examples/vertexai/requirements.txt +COPY lit_nlp/examples/vertexai/requirements.txt \ + lit_nlp/examples/vertexai/requirements.txt RUN python -m pip install -r lit_nlp/examples/vertexai/requirements.txt # Copy the rest of the lit_nlp package @@ -67,11 +66,11 @@ COPY . ./ # Build front-end with yarn WORKDIR $APP_HOME/lit_nlp/client -ENV NODE_OPTIONS "--openssl-legacy-provider" +ENV NODE_OPTIONS="--openssl-legacy-provider" RUN yarn && yarn build && rm -rf node_modules/* # Run LIT server # Note that the config file supports configuring the LIT demo that is launched # via the DEMO_NAME and DEMO_PORT environment variables. WORKDIR $APP_HOME -ENTRYPOINT ["gunicorn", "--config=gunicorn_config.py"] \ No newline at end of file +ENTRYPOINT ["gunicorn", "--config=gunicorn_config.py"]