Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive dependencies for the last-updated target #71

Open
ghost opened this issue Nov 17, 2014 · 0 comments
Open

Excessive dependencies for the last-updated target #71

ghost opened this issue Nov 17, 2014 · 0 comments

Comments

@ghost
Copy link

ghost commented Nov 17, 2014

Bug from Marshall Miller:

I believe the repos/my--repos/last-updated target has excessive dependencies. It appropriately depends on the pkglist. and pkglist.blacklist files. The dependencies on Makefile, CONFIG_BUILD, and CONFIG_REPOS seem inappropriate. I believe that if someone has modified these files in a major way, they should be aware that this is a major change, and they should run make bare before attempting subsequent builds.

If we want to prevent someone from shooting themselves in the foot, we could add a file/target whose purpose is to warn the user if they have modified one of these critical files and have not run make bare (or maybe make clean). One way I think this could be implemented is like so:

$(info $(shell cat build_message))

...

build_message: Makefile CONFIG_BUILD CONFIG_REPOS
@echo "WARNING: a critical file was modified; run make clean if critical changes were made" | tee build_message

clean:
...
@echo -n "" > build_message

@ghost ghost added the bug label Nov 17, 2014
@ghost ghost added this to the RHEL 7 milestone Nov 17, 2014
@ghost ghost added the short-task label Apr 23, 2015
@ghost ghost modified the milestones: Future, RHEL_7_Final Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants