cf conventions for dtr #428
Comments
6 tasks
RondeauG
added a commit
that referenced
this issue
Nov 4, 2024
<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
- This PR fixes #428
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.
### What kind of change does this PR introduce?
* Add unit_metadata for the dtr conversion to be clear that this is a
difference and not convert the units in a non-sensical way.
* Added unit update for delta. If it's a temperature xclim will add the
unit_metadata. Do we want this for the climatological delta ?
### Does this PR introduce a breaking change?
yes, changes the attrs
### Other information:
* this needs to wait for the next xclim release for the new functions.
* Should we add `temperature: on_scale` for `tasmax_from_dtr` and
`tasmin_from_dtr` or is it unecessary?
* Is it necessary somewhere else ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Generic Issue
Following Ouranosinc/xclim#1836, our dtr conversion should probably follow the the convention also.
The text was updated successfully, but these errors were encountered: