Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better control on the inputs of robustness_categories #300

Open
1 task done
RondeauG opened this issue Dec 6, 2023 · 0 comments
Open
1 task done

Better control on the inputs of robustness_categories #300

RondeauG opened this issue Dec 6, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@RondeauG
Copy link
Collaborator

RondeauG commented Dec 6, 2023

Addressing a Problem?

Currently (as of #299), the output of robustness_fractions is given directly to robustness_categories. This means that the function will use changed and agree to output the agreement on the direction (strong/no change/conflicting), but not the actual direction itself.

Potential Solution

Instead of agree, I think that sending agree_positive would accomplish what I need. This could be an argument somewhere, either here in xscen or in xclim.

Additional context

I need to be able to compute the "Direction" categories used in the Hydroclimatic Atlas, with a potential 6th category for "Conflicting signals": https://cehq.gouv.qc.ca/atlas-hydroclimatique/carte-indicateurs/index.htm

image

Contribution

  • I would be willing/able to open a Pull Request to contribute this feature.
@RondeauG RondeauG added the enhancement New feature or request label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant