Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin dask higher, skip dask v2024.11.0 #1991

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Pin dask higher, skip dask v2024.11.0 #1991

merged 3 commits into from
Nov 11, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 11, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Sets the lowest dask pin to the version that dropped Python 3.9 support.
  • Temporarily pins dask below version 2024.11.0 as this version has changed chunking behaviour.

Does this PR introduce a breaking change?

Not really. It should not affect relatively recent builds/installations.

Other information:

https://numpy.org/neps/nep-0029-deprecation_policy.html
https://docs.dask.org/en/stable/changelog.html#v2024-11-1

@Zeitsperre Zeitsperre added the dependencies Pull requests that update a dependency file label Nov 11, 2024
@Zeitsperre Zeitsperre self-assigned this Nov 11, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Nov 11, 2024
@coveralls
Copy link

Coverage Status

coverage: 89.398% (-0.02%) from 89.417%
when pulling e9c69dd on pin-dask
into 4198e8b on main.

@Zeitsperre Zeitsperre merged commit 6328114 into main Nov 11, 2024
21 checks passed
@Zeitsperre Zeitsperre deleted the pin-dask branch November 11, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coxipi coxipi coxipi approved these changes

@aulemahal aulemahal Awaiting requested review from aulemahal

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @coveralls @coxipi