Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Remove old MBCn cells in sdba.ipynb #1895

Merged
merged 10 commits into from
Sep 16, 2024
Merged

FIX: Remove old MBCn cells in sdba.ipynb #1895

merged 10 commits into from
Sep 16, 2024

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Aug 28, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Old unused cells in sdba.ipynb were removed

Does this PR introduce a breaking change?

No

Other information:

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the docs Improvements to documenation label Aug 28, 2024
@Zeitsperre
Copy link
Collaborator

@coxipi The failing tests are expected until the testing changes are in!

@coxipi coxipi added the approved Approved for additional tests label Sep 4, 2024
@coveralls
Copy link

Coverage Status

coverage: 89.402%. remained the same
when pulling ec1b725 on fix_mbcn_nb
into dec486e on main.

@coxipi coxipi requested a review from Zeitsperre September 10, 2024 13:06
Zeitsperre
Zeitsperre approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coxipi coxipi merged commit 08656c1 into main Sep 16, 2024
20 of 21 checks passed
@coxipi coxipi deleted the fix_mbcn_nb branch September 16, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs Improvements to documenation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coxipi @Zeitsperre @coveralls