-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pylint fixes, remove deprecated functions #1881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but maybe double check the loops that you changed
@aulemahal @coxipi This is good for final review! |
Co-authored-by: Pascal Bourgault <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
The notebooks have been fixed in #1889. It likely makes more sense to merge that PR first before this one. |
…ons to _types.py and _exceptions.py, use absolute imports
…ed operations in helpers.py, update __all__ in stats.py, other small fixes
I've made one or two small breaking changes:
The rest of the changes are to clarify internal logic within functions via renaming. Thanks in advance for the re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Well done, thanks.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
pylint
-related warnings.vulture
dependency inenvironment.yml
numpy
*xarray
typing issues.pint
usage.Does this PR introduce a breaking change?
Yes, several calendar-related functions that were deprecated and slated for removal in
xclim
v0.50 and v0.51 have been removed. These will need to be listed in theCHANGELOG.rst
.Other Information:
I'm now a conda-forge maintainer for
vulture
, haha (https://github.com/conda-forge/vulture-feedstock)