Create _streamflow_flow_indices.py #1832
Conversation
streamflow_flow_indice is a submodule in the xclim indices module to calculate streamflow signatures, representing individual watershed characteristics of large river/lake basins.
github-actions
bot
added
docs
|
Welcome, new contributor! It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the
Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨ |
for more information, see https://pre-commit.ci
|
There was a problem hiding this comment.
If the flow_index is not in the literature, I suggest to remove it from this PR and keep it in your project scripts.
Once this PR is merged in, I think it would be interesting to look at additional indices that requires other variables like precipitation, as I think it would provide better physical understanding of processes.
The next step will be to write a test for each index to make sure it behaves as expected. You'll see plenty of examples in the test directory.
for more information, see https://pre-commit.ci
Co-authored-by: David Huard <[email protected]>
Co-authored-by: David Huard <[email protected]>
faimahsho
force-pushed
the
Watershed-indices
branch
from
1a48fe2 to
70e0174
Compare
faimahsho
force-pushed
the
Watershed-indices
branch
2 times, most recently
from
948fa30 to
0507d4c
Compare
faimahsho
force-pushed
the
Watershed-indices
branch
from
8641c3b to
bb69dd4
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Looks good. Please review the changes I just pushed, and add tests for the "indicators" I created.
Note that I added an indexer argument, which lets you pick a season or specific months. Let me know if you believe this is useful or not.
I think the next step would be to have Louise review the finalized PR.
faimahsho
force-pushed
the
Watershed-indices
branch
3 times, most recently
from
d8ae74d to
7beffe9
Compare
…ean over whole period. This part of the analysis can be done on the user-side. Added support for **indexer, allowing more freedom when selecting the period
faimahsho
force-pushed
the
Watershed-indices
branch
from
7beffe9 to
4e086d6
Compare
Co-authored-by: Trevor James Smith <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
This looks good to me.
Here are a few "incoherences" I see, but that may well be expected.
- The high flow is computed with reference fo the median while the low flow is done with reference to the mean. Normal ?
- The high and low flows have their reference computed over the whole period (year) and then the number of days is counted over the temporal subset. The flox index computes both the percentile and the median only over the subset.
…nfusion outweighs the benefits.
streamflow_flow_indice is a submodule in the xclim indices module to calculate streamflow signatures, representing individual watershed characteristics of large river/lake basins.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
This can develop unique watershed attributes.
Other information: