-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Furo documentation theme #1731
Conversation
…ion logo, move indicators.json to _dynamic folder
@aulemahal (and @SarahG-579462) Tagging you here for the JavaScript magic. I think the |
@Zeitsperre Fixed the javascript and html injection! Furo simply uses a different base template name and jinja blocks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! I think there's a little css fiddling needed still.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues with the css, and some suggestions.
for more information, see https://pre-commit.ci
… for better accessibility
I think that if we fix the jupyter notebook issue on |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my concerns have been addressed. This is nice to look at!
This latest commit fixes the issue with xarray not working in "auto" mode. It is not the prettiest solution, since it requires redefining the xarray theme variables in the body tag. (in I chose to update the xarray css variables (e.g. Other options would have been:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! The logo looking unintuitive is very minor, and more a furo issue anyway.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
sphinx-rtd-theme
for thefuro
documentation themeconf.py
to make use of specific variables forfuro
pygments
themes and CSS overrides have been added to ensure adequate contrast of documentation elements in both "dark" and "light" modesxclim/data/__init__.py
,xclim/core/locales.py
,xclim/core/formatting.py
, and othersgenerate_indicator_docstring
has been adjusted to ensure that information blocks (e.g.Parameters
,Returns
) always have newlines between them and that call signature attributes are indented four (4) spaces instead of two (2)pygments
-affected code blocks inextendxclim.ipynb
have been modified to produce nicer outputsDoes this PR introduce a breaking change?
Yes.
furo
, which gives us a dark mode for free as well as better navigation scroll bars when viewing pages in landscape mode.Parameters
items conform strictly tonumpy
-docstring format (indentations of four spaces for attributes, changed from two spaces).Other information:
The load order of layouts appears to be slightly different, and I'm having trouble getting the
indicators.rst
search bar to load properly. Likely a very small change is needed.