Fix: QuantileDeltaMapping not working for seasonal grouping #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aulemahal
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
test_seasonaltest to the QDM suitnumber) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
interp_on_quantilesseasons are now cast to integers to ensure we can add_cyclic_bounds. For this, I also had to overwrite the get_index function of theGrouperclass. On a first class, I think that makes sense since in any case it doesn't make much sense to interp a string variable.Does this PR introduce a breaking change?
Hopefully not.