-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builds for windows and macOS #1648
Conversation
On inspection, the No further action is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks!
I see the test pass, does this mean #1500 can be closed ? (I should read the PR I review)
No, you're right, this unfortunately doesn't resolve #1500, but I now know why the windows call to I'm going to try running I'm going to add a call to |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
.lock
file generated in the cache is now removed after the testing data has been copied, and the file lock has been released.prefetch
argument fortox
is now available for general testing environments.Does this PR introduce a breaking change?
No.
Other information:
The
approved
tag is listed here to ensure that the relevant builds are being triggered. This PR still requires review approval.In order to run Windows build tests,
$ xclim prefetch_testing_data
must be called first to gather the testing data.Did you know that Windows doesn't support Unix-style File Locking (
fcntl
)? This was what was preventing asynchronous handling of testing data fetching from working.