-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More generic generic.stats
- Allow 3H inputs
#1498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huard
approved these changes
Oct 11, 2023
Maybe add a quick test ? |
aulemahal
changed the title
More generic
More generic Oct 11, 2023
generic.stats
generic.stats
- Allow 3H inputs
…genericer-generic
Woups good call. Because the initial issue of Marco was with 3H input, I tested with that. Turns out |
Zeitsperre
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
generic.STATS
so it accepts non-daily inputs. I saw no particular reason for it to be limit to daily values, except from the metadata.op
ofto_agg_units
.out_units
toselect_resample_op
so that one can use it with anop
to_agg_units
doesn't know, and explicitly pass the expected units.Does this PR introduce a breaking change?
Not a big one, but all YAML indicators previous constructed from
select_resample_op
should addout_units: null
in theirparameters
section to remove the new argument from the signature. Altough its presence is not problematic in itself.Other information: