Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple dimensions in stats.fit #1715

Closed
2 tasks done
huard opened this issue Apr 18, 2024 · 2 comments
Closed
2 tasks done

Support multiple dimensions in stats.fit #1715

huard opened this issue Apr 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@huard
Copy link
Collaborator

huard commented Apr 18, 2024

Addressing a Problem?

stats.fit takes a dimension string, but I think it would be useful to be able to specify a list of dimensions, to fit parameters over data from multiple dimensions (e.g. time and realization).

Potential Solution

No response

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to contribute this feature.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@huard huard added the enhancement New feature or request label Apr 18, 2024
@huard huard self-assigned this Apr 18, 2024
@aulemahal
Copy link
Collaborator

Is the solution as easy as :

daStckd = da.stack(stat_dim=['time', 'realization'])
stats.fit(daStckd)

?

If yes, could this be an example somewhere instead ?

@huard
Copy link
Collaborator Author

huard commented Apr 18, 2024

Yes, that's indeed the easiest way to solve this. I wonder if it's worth supporting out of the box. Maybe not.

@huard huard closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants