-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PET calculation with the Hargreaves Modificated method (Droogers and Allen, 2002) #1710
Comments
Hi @JavierDiezSierra, We will happily welcome a PR to add this new method and the other fix to the PET computation. The transition from your function to xclim's implementation looks relatively easy to do. Thanks! |
Hi @JavierDiezSierra, it's always great to see more and more research groups making use of For the modified Hargreaves constant, would it make more sense to propose that it be called via If I understand correctly, the We can help with getting the code and documentation consistent once the PR is opened. Thanks again! |
@Zeitsperre and @aulemahal thank you very much for responding so quickly and for showing interest in including this new method. @Zeitsperre, I think the codes ( @aulemahal, I agree that the transition from my function to xclim's implementation is relatively easy to do ;-) Many many thanks! |
Hi @aulemahal, I have just created the pull request: JavierDiezSierra:da02 |
…2002) (#1723) <!--Please ensure the PR fulfills the following requirements! --> <!-- If this is your first PR, make sure to add your details to the AUTHORS.rst! --> ### Pull Request Checklist: - [X] This PR addresses an already opened issue (for bug fixes / features) - This PR closes #1710 - [X] Tests for the changes have been added (for bug fixes / features) - [X] (If applicable) Documentation has been added / updated (for bug fixes / features) - [X] CHANGES.rst has been updated (with summary of main changes) - [X] Link to issue (:issue:`1710`) and pull request (:pull:`1723`) has been added ### What kind of change does this PR introduce? This change introduces a new method to calculate potential evapotranspiration based on Droogers and Allen (2002). The method incorporates precipitation as a proxy for humidity and is more appropriate for dry regions ### Does this PR introduce a breaking change? No ### Other information:
Generic Issue
Description
In the context of the Copernicus Climate Atlas (https://atlas.climate.copernicus.eu/atlas) we (https://github.com/SantanderMetGroup) are calculating the SPEI with different PET (Potential Evapotranspiration) methods.
We are using xclim during the index computation workflow to ensure process traceability and also because we want to use tools that are aligned with the Copernicus roadmap.
The xclim.indices.potential_evapotranspiration() function includes several methods that we are testing, comparing the results with our in-house functions. Currently, we have validated two of the available methods ("thornthwaite48" and "hargreaves85"), and we would like to implement the modificated "hargreaves85" method (Droogers and Allen 2002; https://doi.org/10.1023/A:1015508322413), which includes precipitations as a proxy for humidity (when precipitation occurs, the air contains humidity, thus reducing PET).
If you are interested in including this new method, we can submit a pull request and provide you with the documentation. Bellow, you'll find our in-house function to calculate the modified method which uses precipitation. This function also implements the "hargreaves85" method because we noticed that the formulation used in xclim is not exactly the same as the one available in the original paper (Hargreaves and Zohrab A. Samani 1985). The xclim formulation (
xclim/xclim/indices/_conversion.py
Line 1285 in bb39cb1
Many thanks for your help!
Code of Conduct
The text was updated successfully, but these errors were encountered: