Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist_method does not work for nnlf #1683

Closed
1 of 2 tasks
huard opened this issue Mar 20, 2024 · 0 comments · Fixed by #1714
Closed
1 of 2 tasks

dist_method does not work for nnlf #1683

huard opened this issue Mar 20, 2024 · 0 comments · Fixed by #1714
Assignees
@huard
Labels
bug Something isn't working
Milestone
v0.49.0 (PyCon LT)

Comments

@huard
Copy link
Collaborator

huard commented Mar 20, 2024

Setup Information

  • Xclim version: 0.46

Description

xclim.indices.stats.dist_method complains about x being defined twice.

The signature of nnlf is (theta, x), which is different from most of the other methods (x, *args).

Steps To Reproduce

No response

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to address this bug.

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huard huard

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.49.0 (PyCon LT)
2 participants
@huard @Zeitsperre