Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdba map_blocks fails with non-dask inputs when sdba_encode_cf option is activated #1673

Closed
1 task done
aulemahal opened this issue Mar 7, 2024 · 0 comments · Fixed by #1674
Closed
1 task done
Assignees
Labels
bug Something isn't working sdba Issues concerning the sdba submodule.

Comments

@aulemahal
Copy link
Collaborator

Generic Issue

  • xclim version: 0.48.2
  • Python version: all
  • Operating System: all

Description

See Ouranosinc/xscen#362

We cycle of the coords dict and modify it during the loop, which fails.

xclim/xclim/sdba/base.py

Lines 676 to 678 in 4546f28

for name, crd in ds.coords.items():
if xr.core.common._contains_cftime_datetimes(crd.variable): # noqa
ds[name] = xr.conventions.encode_cf_variable(crd.variable)

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aulemahal aulemahal added bug Something isn't working sdba Issues concerning the sdba submodule. labels Mar 7, 2024
@aulemahal aulemahal self-assigned this Mar 7, 2024
@aulemahal aulemahal changed the title sdba map_groups fails with non-dask inputs when sdba_encode_cf option is activated sdba map_blocks fails with non-dask inputs when sdba_encode_cf option is activated Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant