Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bind rule to the flutter App #35

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

ErebusZ
Copy link
Member

@ErebusZ ErebusZ commented Sep 23, 2024

This PR adds a bug rule for the method Bind, this should trigger an open port on device finding.

@ohachimOs
Copy link
Member

bind fails so we catch the error to avoid crash? can we maybe attempt to bind to another port? or just wait a bit a try again, sometimes there is a bit of lag with the TIME_WAIT state, if the port was recently bind to something (it could be the same app that had just closed), is it not worth it to try in this use case?
Also can you add a description

@ErebusZ
Copy link
Member Author

ErebusZ commented Sep 23, 2024

TIME_WAIT

That is a little bit behind the point of the app, this code is meant for testing the platform detection ability. invoking bind with vulnerable args is enough to do that.

@3asm
Copy link
Member

3asm commented Sep 23, 2024

@ErebusZ please add a description.

@ErebusZ
Copy link
Member Author

ErebusZ commented Sep 24, 2024

@ErebusZ please add a description.

Added.

ostorlab_insecure_flutter_app/lib/bugs/bind.dart Outdated Show resolved Hide resolved
@ErebusZ ErebusZ merged commit d89ecf1 into master Sep 24, 2024
2 checks passed
@ErebusZ ErebusZ deleted the fix/fix_install_ndk_step_workflow branch September 24, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants