Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for various extensionpoint-classes to be DI-friendly #821

Open
burningice2866 opened this issue Jan 31, 2023 · 0 comments
Open

Allow for various extensionpoint-classes to be DI-friendly #821

burningice2866 opened this issue Jan 31, 2023 · 0 comments

Comments

@burningice2866
Copy link
Contributor

A lovey thing about C1 CMS is its extensibility and how it relies on static typing. This means though that we get a lot of types that are instantiated via reflection and requires a public constructor without arguments.

Not so nice in the world of Dependency Injection.

This is easily fixed though by replacing Activator.CreateInstance with ActivatorUtilities.CreateInstance

https://github.com/Orckestra/C1-CMS-Foundation/search?q=%22Activator.CreateInstance%22&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant