Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-OP install docu states no tables will be created but I think they will #208

Open
S-Koell opened this issue May 3, 2018 · 1 comment

Comments

@S-Koell
Copy link

S-Koell commented May 3, 2018

https://github.com/OraOpenSource/Logger/blob/master/docs/Installation.md#no-op-option-for-production-environments
"It does not even create the tables so there is absolutely no chance it is doing any logging."

But in the script (logger_no_op.sql) I see no sign of the table NOT being created:

begin
  -- Create Table
  select count(1)
  into l_count
  from user_tables
  where table_name = 'LOGGER_LOGS';

  if l_count = 0 then
    execute immediate '
    create table logger_logs(

I think the table will be created. So either the doc or the script is wrong.

@martindsouza
Copy link
Member

martindsouza commented May 3, 2018

Good point. I think the documentation is incorrect. Will update.

Side note: I think we kept the tables in there as the column%type reference in the package.

@martindsouza martindsouza added this to the Release 3.2.0 milestone May 3, 2018
@martindsouza martindsouza modified the milestones: Release 3.2.0, 3.3.0 May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants