Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify types in src/services/apiTypes.ts #204

Open
benjamin-lyon opened this issue Jan 12, 2024 · 0 comments
Open

refactor: simplify types in src/services/apiTypes.ts #204

benjamin-lyon opened this issue Jan 12, 2024 · 0 comments
Labels
refactor Code restructering

Comments

@benjamin-lyon
Copy link
Contributor

benjamin-lyon commented Jan 12, 2024 •
edited
Loading

Many of these types have almost identical use-cases and structure. We should consider merging them and instead having some of their properties as optional.
@benjamin-lyon benjamin-lyon changed the title Refactor types in apiTysrc/services/apiTypes.ts Refactor types in src/services/apiTypes.ts Jan 12, 2024
@benjamin-lyon benjamin-lyon added Frontend refactor Code restructering and removed Frontend labels Jan 12, 2024
@benjamin-lyon benjamin-lyon changed the title Refactor types in src/services/apiTypes.ts refactor: simplify types in src/services/apiTypes.ts Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Code restructering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamin-lyon