webserver.cpp:610:51: error: 'sid' may be used uninitialized in this function

[dopry]

When creating a release build, this error warning kills the build. I can tell that sid gets assigned on line 563, but the compiler isn't bright enough to see that the two if conditions are mutually inclusive.

Here is the full make output.

g++ -c -Wall -Wno-unknown-pragmas -Werror -Wno-format -O3 -DNDEBUG -I /usr/include/openzwave/ -I /usr/include/openzwave/command_classes/ -I /usr/include/openzwave/value_classes/ -I /usr/include/openzwave/platform/ -I /usr/include/openzwave/platform/unix -I /usr/include/openzwave/cpp/tinyxml/ -I /usr/include/ -o ozwcp.o ozwcp.cpp
g++ -c -Wall -Wno-unknown-pragmas -Werror -Wno-format -O3 -DNDEBUG -I /usr/include/openzwave/ -I /usr/include/openzwave/command_classes/ -I /usr/include/openzwave/value_classes/ -I /usr/include/openzwave/platform/ -I /usr/include/openzwave/platform/unix -I /usr/include/openzwave/cpp/tinyxml/ -I /usr/include/ -o webserver.o webserver.cpp
webserver.cpp: In member function 'const char* Webserver::SendSceneResponse(MHD_Connection*, const char*, const char*, const char*, const char*)':
webserver.cpp:610:51: error: 'sid' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   cnt = Manager::Get()->SceneGetValues(sid, &vids);
                                                   ^
cc1plus: all warnings being treated as errors
make: *** [Makefile:40: webserver.o] Error 1

The simple solution seems to be to init the scene id (sid) as either 0 or atoi((char *)arg1) on line 543.

[daradib]

@dopry yes I had the same compiler warning when Debian packaging. Do you want to try a PR to master?

[Fishwaldo]

The scene stuff is being depreciated in the OZW Dev branch and ultimately OZWCP. Just FYI

[dopry]

I took a stab at it, but my branch had other build problems afterwards I wasn't able to resolve quickly. I'll try Dev when I get a chance to work on it again.

…

On Fri, Sep 8, 2017 at 1:13 AM, Justin Hammond ***@***.***> wrote: The scene stuff is being depreciated in the OZW Dev branch and ultimately OZWCP. Just FYI — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#62 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXqOFDdez_e2APgNp0WVlCoy1XZwjrdks5sgMzjgaJpZM4PJw1l> .

-- Darrel O'Pry The Spry Group, LLC. http://www.spry-group.com 718-355-9767 x101

[daradib]

@Fishwaldo thanks for the heads up! Do you plan to merge dev into master at some point? I have been maintaining the Debian package based on master because there are no releases (#51) - let me know if I should consider switching to dev or waiting for a release.