Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor doc issue: order of responses in match_names #81

Open
mtholder opened this issue Nov 18, 2014 · 2 comments
Open

minor doc issue: order of responses in match_names #81

mtholder opened this issue Nov 18, 2014 · 2 comments
Labels

Comments

@mtholder
Copy link
Member

Is the list of object in response["results"] guaranteed to correspond to the order of the matches in the query? It seems to be, but it would be nice (for client code) if we committed to guaranteeing this.

Also (given that floating point comparisons to the "score" field may make people squeamish), it might be nice to return a boolean "ambiguous" for each match.

@mtholder
Copy link
Member Author

Come to think of it...
we might want (in future versions of the API) to return the results as an object with the query strings as the keys. The order is trickier to deal with when some names do not match.

@mtholder
Copy link
Member Author

nevermind about the "floating point comparisons" part of the ambiguous bool comment. ambiguous could be true even if the score is 1.0, right? (based on the doc's usage of ambiguous).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant