Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy files are UTF-8 #146

Open
jar398 opened this issue Oct 19, 2016 · 1 comment
Open

Taxonomy files are UTF-8 #146

jar398 opened this issue Oct 19, 2016 · 1 comment

Comments

@jar398
Copy link
Member

jar398 commented Oct 19, 2016

Class FileReader documentation says "The constructors of this class assume that the default character encoding and the default byte-buffer size are appropriate. To specify these values yourself, construct an InputStreamReader on a FileInputStream."

I have no idea what the default encoding is, but the results I'm seeing from the taxon_info service are gibberish (e.g. the synonym in OTT id 3717384). I bet that if TaxonomyLoaderOTT.java were changed to follow the above advice, the results would be better. (It would be necessary to check that the JSON is being written in UTF-8 as well.)

(This problem may affect treemachine as well, but it doesn't deal with synonyms, which is where most of the fancy characters lie.)

@jar398
Copy link
Member Author

jar398 commented Apr 2, 2017

Fixed on March 4; need to verify that it really works, then close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant