Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TNRS should organize matches by taxa? #144

Open
jar398 opened this issue Oct 6, 2016 · 0 comments
Open

TNRS should organize matches by taxa? #144

jar398 opened this issue Oct 6, 2016 · 0 comments
Assignees

Comments

@jar398
Copy link
Member

jar398 commented Oct 6, 2016

TNRS results should be organized by taxon, not name match. Currently you can get several results for a single OTT id, which is odd. See OpenTreeOfLife/opentree#860

I don't think we want to lose the match information, though. Maybe we're only talking about a factoring of the TNRS result information. All the matches for one taxon would be gathered together, so we get a list where each component is a taxon and a list of matches. Each match has fields is_synonym, score, nomenclature_code, and is_approximate_match.

TNRS documentation here: https://github.com/OpenTreeOfLife/germinator/wiki/TNRS-API-v3#match_names

Hacking the TNRS to do this is a pain, and this is a transformation that clients can do, so not obvious that the effort is best spent hacking taxomachine, or the client(s).

@jimallman jimallman self-assigned this Dec 7, 2016
jimallman added a commit to OpenTreeOfLife/opentree that referenced this issue Dec 8, 2016
This simplifies the results in OTU mapping when the TNRS returns
multiple "hits" on a single taxon (typically due to synonyms and
alternate spellings). Fixes #860 and
OpenTreeOfLife/taxomachine#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants