Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no fuzzy matching? #52

Open
snacktavish opened this issue Sep 8, 2020 · 3 comments
Open

no fuzzy matching? #52

snacktavish opened this issue Sep 8, 2020 · 3 comments

Comments

@snacktavish
Copy link
Member

It appears that the 'exact' flag in otindex calls may not be doing anything...

``` curl -X POST https://api.opentreeoflife.org/v3/studies/find_studies -H "content-type:application/json" -d '{"property":"ot:focalCladeOTTTaxonName","value":"Ilex", "exact":false, "verbose": false}'````
returns {"matched_studies": [{"ot:studyId": "ot_1984"}, {"ot:studyId": "pg_2827"}]}

curl -X POST https://api.opentreeoflife.org/v3/studies/find_studies -H "content-type:application/json" -d '{"property":"ot:focalCladeOTTTaxonName","value":"Ilix", "exact":false, "verbose": false}'

but a one letter change, or capitalization change, returns nothing.

@mtholder
Copy link
Member

mtholder commented Sep 8, 2020

I think that it doesn't work well for short names. Otherwise the breath first search gets too slow. But @bredelings may know better

@snacktavish
Copy link
Member Author

This is all in otindex - I did try with longer names and failed as well.
But I think we might not do anything with the 'exact' parameter at all!

e.g.

resultlist = qs.query_studies(verbose,property_type,property_value)

@bredelings
Copy link

That's interesting -- what would otindex used to do fuzzy matching? Is there a python module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants