Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up email #6

Open
jamesd-uk opened this issue Jun 30, 2016 · 16 comments
Open

Set up email #6

jamesd-uk opened this issue Jun 30, 2016 · 16 comments

Comments

@jamesd-uk
Copy link

jamesd-uk commented Jun 30, 2016

Email addresses for general contact us, email verification, and DMCA hotline.

@jamesd-uk jamesd-uk self-assigned this Jun 30, 2016
@bates64
Copy link
Contributor

bates64 commented Jun 30, 2016

Also for verifying email addresses, I assume? 📦

@bates64
Copy link
Contributor

bates64 commented Jun 30, 2016

Our policy should probably be like Scratch - you can make an account but until your email is verified you can't upload resources.

@jamesd-uk
Copy link
Author

Ruling out sendgrid because it wants my life story

@jamesd-uk
Copy link
Author

jamesd-uk commented Jun 30, 2016

Sendgrid approved my account O_o

I just need info from @NanaLan

@bates64
Copy link
Contributor

bates64 commented Jul 1, 2016

info

Such as?

Also I'm hoping to use some sort of .env and gitignored file to save api keys and the like - thoughts @MegaApuTurkUltra @liam4?

@bates64 bates64 changed the title Set up Sendgrid Set up email confirmation Jul 1, 2016
@bates64 bates64 changed the title Set up email confirmation Set up email Jul 1, 2016
@bates64 bates64 assigned bates64 and unassigned bates64 Jul 1, 2016
@bates64 bates64 removed this from the Initial Release milestone Jul 1, 2016
@bates64 bates64 added feature and removed wish labels Jul 1, 2016
@towerofnix
Copy link
Member

API keys?

Btw obviously hashed right?

@matthewr6
Copy link

matthewr6 commented Jul 1, 2016

Just store it in an environment variable.

Or actually almost anything but on a git repo :P

@MegaApuTurkUltra
Copy link
Member

MegaApuTurkUltra commented Jul 3, 2016

+1 for environment variables. dotenv is now in package.json so we can easily do environment vars on our local copies

Just don't remove .env from .gitignore :P

@MegaApuTurkUltra
Copy link
Member

MegaApuTurkUltra commented Jul 27, 2016

Any progress on this?

I guess it blocks the "forgot password" feature of #84

@jamesd-uk
Copy link
Author

I have a SendGrid account set up, I'm just waiting for someone to ask me for API keys.

@bates64
Copy link
Contributor

bates64 commented Jul 28, 2016

I have a SendGrid account set up, I'm just waiting for someone to ask me for API keys.

asks

@bates64
Copy link
Contributor

bates64 commented Jul 28, 2016

I've implemented SendGrid in a84fd4f - you can send emails now, but somebody needs to make/get a cross-client email template...

@bates64 bates64 assigned bates64 and unassigned jamesd-uk Jul 28, 2016
@bates64
Copy link
Contributor

bates64 commented Jul 30, 2016

@MegaApuTurkUltra email template pls

@MegaApuTurkUltra
Copy link
Member

We should do the template in handlebars. Can handlebars render to string?

@bates64
Copy link
Contributor

bates64 commented Jul 31, 2016

yep, it can render anything (not just html).

@MegaApuTurkUltra
Copy link
Member

Just set up templating - see https://github.com/OpenSprites/OpenSprites-next/blob/master/server/utils/email.js#L44-L65

Currently an html version and a text version are templated and sent.

I haven't actually tested sending an email though, for lack of a sendgrid api key.

@MegaApuTurkUltra MegaApuTurkUltra added this to the Initial Release milestone Aug 7, 2016
@MegaApuTurkUltra MegaApuTurkUltra removed their assignment Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants