Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify Discord channel on Raid Completion #14

Closed
2 tasks done
nobrayner opened this issue Feb 10, 2021 · 1 comment · Fixed by #19
Closed
2 tasks done

Notify Discord channel on Raid Completion #14

nobrayner opened this issue Feb 10, 2021 · 1 comment · Fixed by #19
Labels
Status: Completed Type: Feature Additional Feature and/or functionality - significant code rewrite or additions

Comments

@nobrayner
Copy link
Contributor

nobrayner commented Feb 10, 2021 •
edited
Loading

  • Update newRaid to send a message to "current raids" discord channel when a new raid is created: Send Webhook Message
    • Add a discordMessageId to raid stats document: will need to use the wait query parameter
  • Update completeRaid to:
    • Delete message from "current raids" channel using the discordMessageId: Delete Webhook Message
    • Send message to "completed raids" channel

For what it's worth, I already created some TS types for sending a Discord webhook for a little GH action I made a while back: https://github.com/nobrayner/discord-webhook/blob/master/src/helpers/discordTypes.ts
@nobrayner nobrayner added Type: Feature Additional Feature and/or functionality - significant code rewrite or additions Status: In Progress labels Feb 10, 2021
@nobrayner
Copy link
Contributor Author

This would benefit from #18, but really needs #7 so that there are sensical titles and metadata to use in the creation/other template.

@nobrayner nobrayner mentioned this issue Feb 14, 2021
Merged
@nobrayner nobrayner changed the title Notify Discord channel on Raid Creation / Completion Notify Discord channel on Raid Completion Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Completed Type: Feature Additional Feature and/or functionality - significant code rewrite or additions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: discord notifications OpenSourceRaidGuild/Guild-Scrivener
1 participant
@nobrayner