Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change presenter get_user_related_models #2449

Closed
Elblinator opened this issue May 27, 2024 · 3 comments · Fixed by #2489 or #2511
Closed

Change presenter get_user_related_models #2449

Elblinator opened this issue May 27, 2024 · 3 comments · Fixed by #2489 or #2511
Assignees
Milestone

Comments

@Elblinator
Copy link
Member

Elblinator commented May 27, 2024

Current behaviour:
The presenter currently gives back meeting ids even if the User is only in there as a remnant and not as a informational important User:
Example response if the User is not ANYMORE in the meeting (but was in there before) and has no other connections to the meeting:

id: 5
is_active_in_organization_id: 1
name: "Meetings Name ABC"

Example response from the presenter if the User is a candidate, a submitter, a speaker and a manager in the same meeting:

{
  "id": 6,
  "name": "Meeting name",
  "is_active_in_organization_id": 1,
  "speaker_ids": [ 20 ],
  "motion_submitter_ids": [ 40 ],
  "assignment_candidate_ids": [ 7 ]
}

Reproduction to get the first response:
It is important that you add User C to (at least) two meetings before removing/deleting them from any

  1. Create User C
  2. Create two meetings
  3. Add C to both meetings
  4. In Meeting A delete User C
  5. In meeting B delete User C
  6. Navigate to the account list
  7. C has no assigned Meetings
  8. Delete User C from the account list
  9. In the deletion dialog both meetings will be listed

Wanted behaviour:
If a User only has a meeting_user_id but is not assigned to any group, or is in one of the other groups (candidate, submitter, speaker) then this meeting Id should not be returned by the presenter

@Elblinator Elblinator added the bug label May 27, 2024
@Elblinator Elblinator added this to the 4.2 milestone May 27, 2024
@Elblinator Elblinator transferred this issue from OpenSlides/openslides-client May 28, 2024
@Elblinator Elblinator changed the title Fix user deletion when user is not in any meeting anymore Change presenter get_user_related_models May 28, 2024
@luisa-beerboom luisa-beerboom self-assigned this Jun 24, 2024
@MSoeb
Copy link

MSoeb commented Jul 3, 2024

Issue is reopened again, because the fix doesn't work well. The old meetings of the user, in which he isn't participant anymore, are still visible.

@MSoeb MSoeb reopened this Jul 3, 2024
@luisa-beerboom
Copy link
Member

And what did you do to get that result?

@MSoeb
Copy link

MSoeb commented Jul 3, 2024

The reproduction steps that are listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment