Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mimetype check accept json #2049

Closed
luisa-beerboom opened this issue Dec 7, 2023 · 1 comment · Fixed by #2057
Closed

Make mimetype check accept json #2049

luisa-beerboom opened this issue Dec 7, 2023 · 1 comment · Fixed by #2057
Assignees
Labels
bug high needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time
Milestone

Comments

@luisa-beerboom
Copy link
Member

luisa-beerboom commented Dec 7, 2023

json files (like meeting export files downloaded in the client) currently fail in mediafile.uploads mimetype check.

This should not be the case

@luisa-beerboom luisa-beerboom added this to the 4.1 milestone Dec 7, 2023
@luisa-beerboom luisa-beerboom self-assigned this Dec 7, 2023
@luisa-beerboom
Copy link
Member Author

I tried writing a test for this:
My manually written json content worked as intended.
When I removed everything but the outer brackets it stopped working (probably because python-magic can't determine the type of something so simple, so it goes for text/plain).

Exported meeting from the client also failed even though it really had all the different property types.
My guess is that there may have been something wrong with the files generated by the client, but they looked fine to me. Maybe the client uses the wrong text encoding or smth?

@luisa-beerboom luisa-beerboom added high needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time labels Dec 7, 2023
@r-peschke r-peschke linked a pull request Dec 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug high needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants