Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Error message for too small vote_weight #2028

Closed
Elblinator opened this issue Nov 29, 2023 · 3 comments
Closed

Change Error message for too small vote_weight #2028

Elblinator opened this issue Nov 29, 2023 · 3 comments
Labels
enhancement General enhancement which is neither bug nor feature

Comments

@Elblinator
Copy link
Member

Current behaviour:
If the vote_weight is too small ( < 0.000001) then the following Error is thrown:

vote_weight must be bigger than or equal to 0.000001.

Wanted behaviour:
If a user with vote_weight <= 0 is saved then the thrown error should be:

vote_weight must be great than 0

If a user with vote_weight >0 but <0.000001 is saved then the following error should be thrown:

vote_weight must be greater than or equal to 0.000001.
@Elblinator Elblinator added the enhancement General enhancement which is neither bug nor feature label Nov 29, 2023
@jsangmeister
Copy link
Contributor

If a user with vote_weight >0 but <0.000001 is saved

This is not possible: The vote weight is limited to 6 decimal places, so 0.000001 is the lowest possible number (that's why we chose it as the minimum).

@jsangmeister
Copy link
Contributor

as discussed, will be solved in the client as the backend always expects a six-digit number

@Elblinator
Copy link
Member Author

Okay, then the client needs to prevent this error from happening and not the backend
The backend issue will be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Development

No branches or pull requests

2 participants