This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
Improve yaml gen prompting #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,18 +66,19 @@ def generate_yaml(self, conversation, string, **kwargs): | |||
| response = llm_chain(inputs={"string": string}) | |||
|
|
|||
| # https://stackoverflow.com/a/63082323/2328066 | |||
| regex = r"(?:\n+|\A)?(?P<code_block>\`{3,}yaml\n+[\S\s]*\`{3,})" | |||
There was a problem hiding this comment.
Assuming that we don't need any extra parsing on response. Looks good to me.
There was a problem hiding this comment.
this is another case of "eventually we will" (at a minimum we should be yaml linting the response to confirm it is indeed a valid yaml response and has no formatting around it) but for now this change gets the api endpoint working again w/ the current model
vishnuchalla
approved these changes
Nov 10, 2023
Merged
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Attempts to ensure we get back an unformatted(no markdown) response from the
model and only get a single resource type (previously was getting back a
not just a deployment but also a service and a PVC, when asking for a mongodb
deployment)
Related Tickets & Documents
Checklist before requesting a review
Testing