Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Path typing isn't consistent #10239

Open
eckter opened this issue Jan 6, 2025 · 0 comments
Open

core: Path typing isn't consistent #10239

eckter opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
area:core Work on Core Service kind:refacto-task Task related to Refactorization Epic

Comments

@eckter
Copy link
Contributor

eckter commented Jan 6, 2025

Path is an interface that can be used to type Length, Offset, and such.

But we have significant issues with what it actually means. When we handle several types of paths, it generally means "0 = start of the first block included in the path". But there are cases where 0 means the departure point (as in, the travelled path).

That's a significant issue. We should unify this, make the semantics consistent, and document it. We should probably remove the ambiguous Path at least temporarily.

@eckter eckter added area:core Work on Core Service kind:refacto-task Task related to Refactorization Epic labels Jan 6, 2025
@eckter eckter self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service kind:refacto-task Task related to Refactorization Epic
Projects
None yet
Development

No branches or pull requests

1 participant