Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion to match the newer version of windef from openpiv 0.24.0 #48

Open
alexlib opened this issue Jun 20, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@alexlib
Copy link
Member

alexlib commented Jun 20, 2022

Following user's request for the windef to work with the sequential data, we adopted your format of sequencing: '(1+2),(3+4)' and so on and made it a part of the openpiv.tools.MultiProcesser:

see here https://github.com/OpenPIV/openpiv-python/blob/e3b185987a729381655d341cc7b358796d846314/openpiv/tools.py#L407

we of course updated documentation - see here:
https://openpiv.readthedocs.io/en/latest/src/windef.html

However, this might interfere with the Tk GUI part (not sure about it).

In any case, please run tests vs 0.24.0 and see if it makes sense to unify this code once in the library and not in the GUI. Of course, it can be just a meaningless work, cause we're still in beta and not finalized the formats.

@alexlib alexlib added the enhancement New feature or request label Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant