Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent drawing enhancement #988

Open
ollesmaps opened this issue Oct 10, 2017 · 4 comments
Open

Fluent drawing enhancement #988

ollesmaps opened this issue Oct 10, 2017 · 4 comments

Comments

@ollesmaps
Copy link

Steps to reproduce

At this moment it is not possible to draw continuously. If you want to draw a line (or area) outside screen, you have to 1) finish line 2) pan map 3) begin a new line 4) merge lines.

Expected behaviour

It would be much better if you could let line be unfinished 1) pan map 2) continue line.

Note

This issue was already mentioned by @mlerjen at #534.

Configuration

Android App 0.7.0

@ollesmaps
Copy link
Author

Sidenote: If you zoom out/ zoom in - you can continue drawing an unfinished line.

@dg0yt
Copy link
Member

dg0yt commented Dec 23, 2018

As much as I understood from this issue and from #1175, #1195, we are talking about using the "Pan" tool transiently here.

@lpechacek This might be implemented by activating the PanTool as an override tool to the current tool, instead of as a replacement. I investigated a little bit, and found that we may need a little bit more API and state handling than we have at the moment. I can share the proof of concept.

@lpechacek
Copy link
Member

As much as I understood from this issue and from #1175, #1195, we are talking about using the "Pan" tool transiently here.

Ack.

@lpechacek This might be implemented by activating the PanTool as an override tool to the current tool, instead of as a replacement.

I noticed the concept of override tool in the sources but haven't studied it yet.

I investigated a little bit, and found that we may need a little bit more API and state handling than we have at the moment. I can share the proof of concept.

That was my conclusion too. Draw path tool state needs to be restored after Pan tool operation is finished. A PoC will surely give a welcome clue. I also won't feel offended if you take over the issue. :)

@ollesmaps
Copy link
Author

Relates to #1851 Pan map window automatically when editing to the edge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants