Improve capone131 image (cloud provider research) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sk4zuzu
commented
Nov 7, 2024
•
sk4zuzu
commented
- Use the k8s.io namespace with ctr (fix)
- Correctly escape dollar sign in kube-vip wrapper (fix)
- Add env vars required by crictl (deprecation)
- Add insecure registry.dev for development use
- Update one-apps submodule
- Use ubuntu2404 image built in one-apps submodule
- Use one-context instead of cloud-init
- Cleanup makefiles
rsmontero
approved these changes
Nov 7, 2024
sk4zuzu
force-pushed
the
cloud-provider-poc
branch
from
f975f1a to
cf02c6e
Compare
- Use the k8s.io namespace with ctr (fix) - Correctly escape dollar sign in kube-vip wrapper (fix) - Add env vars required by crictl (deprecation) - Add insecure registry.dev for development use - Update one-apps submodule - Use ubuntu2404 image built in one-apps submodule - Use one-context instead of cloud-init - Cleanup makefiles
sk4zuzu
force-pushed
the
cloud-provider-poc
branch
from
cf02c6e to
3549a54
Compare
rsmontero
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.