-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add internal caching #6
Comments
What about directly reusing some Tycho clases as API? |
I think the former is how I'd go about doing it - I'd want to make sure that the cache use is compatible with how Tycho does it, and so reusing the same code directly makes the most sense. As for integrating this directly in Tycho, part of it is the daunting prospect of properly contributing to the Tycho codebase, but a more-technical problem is that Tycho already has its own concept of a "p2" repository type that isn't quite the same. However, the actual Maven repository handlers for it in Tycho are, I believe, mostly stubbed out, so it'd likely be possible to add "real" resolution capabilities to them without disrupting their existing use as hooks for the Equinox resolver Tycho uses. |
the codebase has some complex part, but some parts are, I hope, easy enough to contribute to.
I don't think there is a difference in the definition of a p2 repository. How it can be used or not can make a difference but...
This resolver are only used for the eclipse-plugin, eclipse-feature, eclipse-repository and other Tycho-specific packaging types; they wouldn't interfer for a plain "jar" project. And even if there are some conflicts at execution, I think it would still be valuable for Tycho, and for this code, to have it as a separate org.eclipse.tycho:p2-resolution extension, but inside Tycho. |
It'd probably be best to add some filesystem caches like Tycho, but that always has some expiration problems.
The text was updated successfully, but these errors were encountered: