Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapable peer dependency #378

Open
ylavoie opened this issue Feb 18, 2024 · 2 comments
Open

Tapable peer dependency #378

ylavoie opened this issue Feb 18, 2024 · 2 comments

Comments

@ylavoie
Copy link

ylavoie commented Feb 18, 2024

Tapable is required by the plugin but listed as peer, forcing users to add it or have npm/yarn complains about unmet peer dependency.
Shouldn't it be a real dependency of the plugin?

@chuckdumont
Copy link
Collaborator

You're probably right, but I'm afraid to change it at this point for fear of breaking builds for people who have it working. Is adding Tapable as a dependency a problem for you?

@ylavoie
Copy link
Author

ylavoie commented Feb 20, 2024

More an annoyance than a problem, I have no need for tapable but need to include in my dependencies to quiet the builds.
Users who need it should already have it in their dependencies, others shouldn't see any difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants