-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions Lint: weblint #1863
GitHub Actions Lint: weblint #1863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should either be new web lint, or we should add a todo to potentially check the old Google Closure one too at some point...
Plus @FloEdelmann actions comment
Co-authored-by: Flo Edelmann <[email protected]>
@peternewman Annotation check is failing because Python 2.7 is no longer supported by EDIT: Opened #1865 |
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
I couldn't find this in the old Travis CI version. Was this ever tested/ran with the CI previously? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fixes @DaAwesomeP !
I think this can definitely be a TODO/future issue/item in the main CI TODO, but it seems this was actually done on the RDM App, by @FloEdelmann as it happens: |
Added to the list in #1815! |
This one ended up being pretty simple!
@kripton I had to add a
package-lock.json
. Please let me know if what I generated is acceptable or if you have a different version from your own machine. If the latter, then please push it to branch `0.10 or suggest/modify the file in this pull.