Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Lint: weblint #1863

Conversation

DaAwesomeP
Copy link
Member

This one ended up being pretty simple!

@kripton I had to add a package-lock.json. Please let me know if what I generated is acceptable or if you have a different version from your own machine. If the latter, then please push it to branch `0.10 or suggest/modify the file in this pull.

Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should either be new web lint, or we should add a todo to potentially check the old Google Closure one too at some point...

Plus @FloEdelmann actions comment

.github/workflows/lint.yaml Outdated Show resolved Hide resolved
@DaAwesomeP
Copy link
Member Author

DaAwesomeP commented Jun 19, 2023

@peternewman Annotation check is failing because Python 2.7 is no longer supported by setup-python. See actions/setup-python#672.

EDIT: Opened #1865

.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
@DaAwesomeP
Copy link
Member Author

This should either be new web lint, or we should add a todo to potentially check the old Google Closure one too at some point...

I couldn't find this in the old Travis CI version. Was this ever tested/ran with the CI previously?

Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes @DaAwesomeP !

@peternewman
Copy link
Member

I couldn't find this in the old Travis CI version. Was this ever tested/ran with the CI previously?

I think this can definitely be a TODO/future issue/item in the main CI TODO, but it seems this was actually done on the RDM App, by @FloEdelmann as it happens:
https://github.com/OpenLightingProject/rdm-app/pull/128/files

@peternewman peternewman merged commit 43e7654 into OpenLightingProject:0.10 Jun 21, 2023
@DaAwesomeP
Copy link
Member Author

I couldn't find this in the old Travis CI version. Was this ever tested/ran with the CI previously?

I think this can definitely be a TODO/future issue/item in the main CI TODO, but it seems this was actually done on the RDM App, by @FloEdelmann as it happens: https://github.com/OpenLightingProject/rdm-app/pull/128/files

Added to the list in #1815!

@peternewman peternewman added this to the 0.10.10 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants