Skip to content

Commit

Permalink
Merge pull request #1875 from peternewman/0.10-c11-compat
Browse files Browse the repository at this point in the history
Fix protoc version checking, since v20.x
  • Loading branch information
peternewman authored Dec 12, 2023
2 parents 8142298 + 0270390 commit aed518a
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion config/ola.m4
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,14 @@ if test -z "$PROTOC" ; then
AC_MSG_ERROR([cannot find 'protoc' program]);
elif test -n "$1" ; then
AC_MSG_CHECKING([protoc version])
[protoc_version=`$PROTOC --version 2>&1 | grep 'libprotoc' | sed 's/.*\([0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\).*/\1/g'`]
# Since v20.x we only get effectively the minor and patch versions out of protoc.
# Treat them as major and minor and everything should keep working indefinitely.
# See https://protobuf.dev/support/version-support/
# So we've got either of these:
# libprotoc 2.4.1
# libprotoc 23.3
# The first sed ensures all versions have major, minor, patch, by adding a .0 on the end of ones missing it
[protoc_version=`$PROTOC --version 2>&1 | grep 'libprotoc' | sed 's/\([^\.0-9][0-9][0-9]*\.[0-9][0-9]*\)$/\1\.0/g' | sed 's/[^0-9]*\([0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\).*/\1/g'`]
[required=$1]
[required_major=`echo $required | sed 's/[^0-9].*//'`]
[required_minor=`echo $required | sed 's/[0-9][0-9]*\.\([0-9][0-9]*\)\.[0-9][0-9]*/\1/'`]
Expand Down

0 comments on commit aed518a

Please sign in to comment.