Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple pill labels show outside of guide cards for certain screen sizes #3711

Closed
SteveSamJacob19 opened this issue Apr 29, 2024 · 8 comments · Fixed by #3718, #3735 or #3740
Closed

Multiple pill labels show outside of guide cards for certain screen sizes #3711

SteveSamJacob19 opened this issue Apr 29, 2024 · 8 comments · Fixed by #3718, #3735 or #3740
Assignees
Labels
bug Problems found in prod branch

Comments

@SteveSamJacob19
Copy link
Contributor

There is a bug on the tags in the guides page when the screen size is reduced as shown below.

Screenshot 2024-04-24 at 6 25 58 PM
@SteveSamJacob19 SteveSamJacob19 added the bug Problems found in prod branch label Apr 29, 2024
@github-project-automation github-project-automation bot moved this to New (Untriaged) in Website backlog Apr 29, 2024
@navaneethsnair1
Copy link
Contributor

@SteveSamJacob19 It seems to be working fine. I tried them in chrome and safari.

@SteveSamJacob19
Copy link
Contributor Author

Actually when I looked in the morning, it looked fine to me too, but I played around with the screen size and the issue popped up again randomly. I've shared a recording of the same.

Screen.Recording.2024-04-30.at.12.42.34.PM.mov

@SteveSamJacob19
Copy link
Contributor Author

It apparently only affects some boxes

@natalie-bernhard
Copy link
Contributor

It's dependent on whether the guide has multiple pill labels or just one (set in guides.html). We will probably have to limit the labels to one label per card at this time. Make sure to confirm with guides team which labels should be prioritized.

@natalie-bernhard natalie-bernhard moved this from New (Untriaged) to Backlog (Ready to Start) in Website backlog May 1, 2024
@SteveSamJacob19
Copy link
Contributor Author

SteveSamJacob19 commented May 2, 2024

@natalie-bernhard actually if you watch the recording, you can see that some boxes with multiple labels (eg: run in cloud and updated tag together) don't have the bug while some do.

@natalie-bernhard
Copy link
Contributor

@SteveSamJacob19 The initial screenshot submitted from the issue clearly shows a bug when these two tags (run in cloud and updated) are both present in a card. The only cards that don't seem to be affected are the ones with the New label since that is a shorter label.

@SteveSamJacob19
Copy link
Contributor Author

SteveSamJacob19 commented May 2, 2024

@natalie-bernhard I thought the same too at first but actually if you go through the recording at around the 2 second timestamp, you can see a card with run in cloud and updated tags having no bug in it.

@SteveSamJacob19
Copy link
Contributor Author

SteveSamJacob19 commented May 2, 2024

@natalie-bernhard So I played around with the screen width right from full screen to the least width possible. I noticed that issue happens only when the window.innerWidth is between 1400 and 1435 px, Because below 1400 breakpoint the window only shows 3 cards at a time while above 1435 the 4 cards have enough space between them.

@SteveSamJacob19 SteveSamJacob19 self-assigned this May 2, 2024
@SteveSamJacob19 SteveSamJacob19 linked a pull request May 2, 2024 that will close this issue
5 tasks
@SteveSamJacob19 SteveSamJacob19 moved this from Backlog (Ready to Start) to Ready for Review in Website backlog May 2, 2024
@SteveSamJacob19 SteveSamJacob19 linked a pull request May 15, 2024 that will close this issue
5 tasks
@natalie-bernhard natalie-bernhard changed the title Bug on tags in Guides page Multiple pill labels show outside of cards for certain screen sizes May 15, 2024
@natalie-bernhard natalie-bernhard changed the title Multiple pill labels show outside of cards for certain screen sizes Multiple pill labels show outside of guide cards for certain screen sizes May 15, 2024
@natalie-bernhard natalie-bernhard mentioned this issue May 17, 2024
5 tasks
@github-project-automation github-project-automation bot moved this from Ready for Review to Closed/Done in Website backlog May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problems found in prod branch
Projects
Status: Closed/Done
3 participants