Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive Guides table of contents isn't fully appearing in Chrome #3463

Closed
steven1046 opened this issue Oct 26, 2023 · 4 comments · Fixed by #3692, #3696 or #3704
Closed

Interactive Guides table of contents isn't fully appearing in Chrome #3463

steven1046 opened this issue Oct 26, 2023 · 4 comments · Fixed by #3692, #3696 or #3704
Assignees
@SteveSamJacob19
Labels
bug Problems found in prod branch

Comments

@steven1046
Copy link
Member

steven1046 commented Oct 26, 2023 •
edited
Loading

https://openliberty.io/guides/microprofile-config-intro.html
As you can see the toc is hidden somewhat on the initial load:
image
@steven1046 steven1046 added the bug Problems found in prod branch label Oct 26, 2023
@github-project-automation github-project-automation bot moved this to New (Untriaged) in Website backlog Oct 26, 2023
@steven1046 steven1046 changed the title Interactive Guides TOC isn't fully appearing in Chrome Interactive Guides table of contents isn't fully appearing in Chrome Oct 26, 2023
@SteveSamJacob19 SteveSamJacob19 self-assigned this Oct 31, 2023
@steven1046 steven1046 moved this from New (Untriaged) to In Development in Website backlog Nov 1, 2023
@SteveSamJacob19 SteveSamJacob19 moved this from In Development to In Testing/Review in Website backlog Nov 20, 2023
@SteveSamJacob19 SteveSamJacob19 linked a pull request Nov 20, 2023 that will close this issue
Fixed appearance of TOC in interactive guides #3494
Closed
@SteveSamJacob19 SteveSamJacob19 removed their assignment Dec 4, 2023
@natalie-bernhard natalie-bernhard moved this from In Testing/Review to Backlog (Ready to Start) in Website backlog Jan 17, 2024
@steven1046
Copy link
Member Author

Try scrolling to 0 after the page is ready

@natalie-bernhard natalie-bernhard moved this from Backlog (Ready to Start) to In Design/Discussion in Website backlog Mar 13, 2024
@natalie-bernhard natalie-bernhard moved this from In Design/Discussion to Backlog (Ready to Start) in Website backlog Mar 13, 2024
This was linked to pull requests Mar 28, 2024
Fixed appearance of Toc in interactive guides #3691
Closed
Fixed cutting of interactive guide toc content #3692
Merged
@SteveSamJacob19 SteveSamJacob19 self-assigned this Mar 30, 2024
@SteveSamJacob19 SteveSamJacob19 moved this from Backlog (Ready to Start) to Ready for Review in Website backlog Mar 30, 2024
@SteveSamJacob19 SteveSamJacob19 linked a pull request Apr 3, 2024 that will close this issue
Fixed appearance of toc in interactive guides #3696
Merged
5 tasks
@SteveSamJacob19 SteveSamJacob19 linked a pull request Apr 15, 2024 that will close this issue
Fixed interactive guide toc #3704
Merged
5 tasks
@natalie-bernhard natalie-bernhard mentioned this issue May 1, 2024
Merged
5 tasks
@natalie-bernhard
Copy link
Contributor

The new changes helped this issue but there is still a bug when the user scrolls at all on an iguide, where the TOC becomes cut off again. Putting this back into development for the other part of this issue that needs to be addressed.

@natalie-bernhard natalie-bernhard moved this from Ready for Review to In Development in Website backlog May 1, 2024
@SteveSamJacob19
Copy link
Contributor

With reference to the bug mentioned by @natalie-bernhard , its actually a common bug that occurs for both static and interactive guides and occurs when the toc is longer than the window, in which case, on scrolling the guide content, a scrollbar is generated for the toc too and hence the guides is scrolled back up, the toc does not return to its original state unless it is also scrolled back up.

Screen.Recording.2024-05-02.at.8.43.26.PM.mov

@SteveSamJacob19
Copy link
Contributor

As this bug is not related to this specific issue, I'm closing this issue.

@github-project-automation github-project-automation bot moved this from In Development to Closed/Done in Website backlog May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SteveSamJacob19 SteveSamJacob19

Labels
bug Problems found in prod branch
Projects
Website backlog
Status: Closed/Done
Milestone
No milestone
3 participants
@steven1046 @natalie-bernhard @SteveSamJacob19