Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for the start action for command using mvn/gradle #398

Merged

Conversation

SuparnaSuresh
Copy link
Contributor

Fixes #397

Changes added for the command executing using mvn/gradle for windows - terminals cmd and poweshell

Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Looking at the new method name and comment:

/**
 * Returns default format for the command with Path  
 */
function formDefaultCommandWithPath(projectPath: string, buildFilePath: String, command: string, cmdOption: String, customCommand?: string)

Both the comment and name should be updated to be more clear. This was confusing at first because the method still used projectPath and buildFilePath. Looking at where this method is called, it eventually became clear that this is referring to the "executable" path or the "build command" path.

Please open an issue to improve the name and explanation of this method. It can be addressed in the next release.

@TrevCraw TrevCraw merged commit 312b178 into OpenLiberty:main Nov 27, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start actions not working in LTV dashboard using mvn command
3 participants