Migrated the code base to manifest v3 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambarvm
reviewed
Oct 24, 2022
| @@ -407,7 +407,7 @@ | |||
| "maxArgs": 2 | |||
| } | |||
| }, | |||
| "pageAction": { | |||
| "Action": { | |||
There was a problem hiding this comment.
Modifying this file is less than ideal because this is library code. The polyfill does not support MV3.
Moreover, it might not be needed anymore since chrome now supports many promise based APIs.
Try replacing this file with:
const global = typeof globalThis !== 'undefined' ? globalThis : typeof self !== 'undefined' ? self : this
global.browser = typeof browser === 'undefined' ? chrome : browser
ambarvm
reviewed
Oct 24, 2022
| @@ -16,8 +16,7 @@ | |||
| "default_title": "CGPA" | |||
| }, | |||
| "background": { | |||
| "scripts": ["browser-polyfill.js", "background.js"], | |||
| "persistent": false | |||
| "service_worker": "worker-wrapper.js" | |||
There was a problem hiding this comment.
Firefox MV3 is currently in beta and does not support background service worker.
Lets wait for merging this. We can merge this when firefox supports this.
If that does not happen before chrome ends mv2 support, we can create a script to generate 2 different manifest files.
ambarvm
added
the
hacktoberfest-accepted
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the manifest.json to the new version of manifest and made the corresponding changes to other files. Added new file worker-wrapper.js to include multiple background scripts in service_worker.
Tested and is working fine.