-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding youtube videos to the gallery #43
Comments
Hi Remco,
Actually this would be a huge undertaking... however, overhauling the Gallery has been on my list for a while.
Instead of just supporting YouTube, perhaps the "new" Gallery could support not only images, but videos hosted on a number of platforms (i.e. Vimeo etc). This is something that has come up a few times over the years and I do see that there is room for improvement with the Gallery. I think it's worth starting a GitHub Discussion in order to garner input on what features a Waymark Gallery v2.0 might look like. Thanks for the suggestion! |
What did you have in mind to change about the gallery? Because for me the gallery works very well. I've tried experimenting with a few things, like placing multiple rows of images. but for me it all took away from the main focus, the map. So I only ended up making the thumbnails a little bigger. Aside from adding video's my only 2 other "wishes" would be to have a fancybox integration (saw something in the docs but haven't had time to look into it yet) and the other one is to group images(/videos) on a collection map. But i would love to hear your ideas. And wherever possible i would like to help (although my JS skills are not that great)
Makes sense, Wordpress has the built in embed and video shortcodes that could be used for that |
Thank you, I put a lot of time into this feature :)
I am quite happy with how it works too, aside from a few minor gripes; however making it more customisable and have better "responsive" support for different devices are high on the list. The main issue though is the code behind the Gallery. I wrote this in jQuery a long time ago and it's time for a rewrite of this feature. As part of that, lightbox support and multiple Overlay images were on my list.
I will endeavor to do this and start pooling my thoughts. I will include a link to this, and any other previous discussions I can find. Cheers, Joe |
Thanks for sharing your solution! :) Joe |
Hi Joe,
I don't know if this would be a lot of work, but would it be able to integrate youtube videos into the gallery (and popup?) just like with the photos. I was thinking maybe like an URL field where you can submit the link of the youtube video?
Cheers,
Remco
The text was updated successfully, but these errors were encountered: