Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some YAML files and README.md documents still remain in v1beta1 format #146

Open
juwei008 opened this issue Apr 11, 2024 · 0 comments · May be fixed by #147
Open

Some YAML files and README.md documents still remain in v1beta1 format #146

juwei008 opened this issue Apr 11, 2024 · 0 comments · May be fixed by #147

Comments

@juwei008
Copy link

Starting from version v1.1.0, the core v1beta1 API is deprecated and will be removed in the future. However, in some YAML files and README.md documents, there are still remain in v1beta1 format.
For example:
./functions/async/logs-handler-function/logs-handler-function.yaml: {"apiVersion":"core.openfunction.io/v1beta1","kind":"Function","metadata":{"annotations":{},"name":"logs-async-handler","namespace":"default"},"spec":{"build":{"builder":"openfunction/builder-go:latest","env":{"FUNC_CLEAR_SOURCE":"true","FUNC_NAME":"LogsHandler"},"srcRepo":{"revision":"main","sourceSubPath":"functions/async/logs-handler-function/","url":"https://github.com/OpenFunction/samples.git"}},"image":"openfunctiondev/logs-async-handler:v1","imageCredentials":{"name":"push-secret"},"serving":{"bindings":{"kafka-receiver":{"metadata":[{"name":"brokers","value":"kafka-server-kafka-brokers:9092"},{"name":"authRequired","value":"false"},{"name":"publishTopic","value":"logs"},{"name":"topics","value":"logs"},{"name":"consumerGroup","value":"logs-handler"}],"type":"bindings.kafka","version":"v1"},"notification-manager":{"metadata":[{"name":"url","value":"http://notification-manager-svc.kubesphere-monitoring-system.svc.cluster.local:19093/api/v2/alerts"}],"type":"bindings.http","version":"v1"}},"inputs":[{"component":"kafka-receiver","name":"kafka"}],"outputs":[{"component":"notification-manager","name":"notify","operation":"post"}],"runtime":"async","scaleOptions":{"keda":{"scaledObject":{"advanced":{"horizontalPodAutoscalerConfig":{"behavior":{"scaleDown":{"policies":[{"periodSeconds":15,"type":"Percent","value":50}],"stabilizationWindowSeconds":45},"scaleUp":{"stabilizationWindowSeconds":0}}}},"cooldownPeriod":60,"maxReplicaCount":10,"minReplicaCount":0,"pollingInterval":15}}},"template":{"containers":[{"imagePullPolicy":"IfNotPresent","name":"function"}]},"triggers":[{"metadata":{"bootstrapServers":"kafka-server-kafka-brokers.default.svc.cluster.local:9092","consumerGroup":"logs-handler","lagThreshold":"20","topic":"logs"},"type":"kafka"}]},"version":"v2.0.0"}}
./functions/async/pubsub/README.md:apiVersion: core.openfunction.io/v1beta1
./functions/knative/hello-world-go/README.md: apiVersion: core.openfunction.io/v1beta1
./functions/knative/hello-world-node/commonjs/README.md:apiVersion: core.openfunction.io/v1beta1
......

juwei008 added a commit to juwei008/samples that referenced this issue Apr 11, 2024
…ormat

Starting from version v1.1.0, the core v1beta1 API is deprecated and will be removed in the future. However, in some YAML files and README.md documents, there are still remain in v1beta1 format.

Fixes: OpenFunction#146

Signed-off-by: juwei008 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant