Module hiero-base miss tests for functionality of AccountClientImpl.createAccount #107
Labels
good first issue candidate
Label for issues that should be labeled by 'good first issue' but missing a good documentation
🆕🐥 First Timers Only
This issue is reserved for people who have never contributed to this project or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution.
👾 Description of the issue
In the
hiero-base
module, theAccountClientImpl
class implements thecreateAccount
method, which creates a new account with an initial HBAR balance by interacting with theProtocolLayerClient
. However, this method currently lacks unit and integration tests. Scenarios such as successful account creation, invalid initial balances, and exception handling (e.g.,HieroException
) are untested, leaving this functionality vulnerable to potential issues.Suggested solution
Create a new test class or extend the existing test suite for
AccountClientImpl
to include tests for thecreateAccount
method. Use JUnit to validate positive scenarios like successful account creation and negative scenarios such as invalid HBAR balances and error handling during account creation.📋 Step by step guide to do a contribution
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow.
A more detailed general documentation of the GitHub PR workflow can be found here.
🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽
🤔 Additional informantion
If you have any questions, just ask us directly in this issue by adding a comment. A general manual about open-source contributions can be found here.
The text was updated successfully, but these errors were encountered: