-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new version of functioning xarray IO interactions #1060
base: master
Are you sure you want to change the base?
Conversation
o=SeaLice(loglevel=20,iomodule='xarray'.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleaned up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok that's a mistake I should push this file back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
brought back in
Not sure why it cannot be installed, perhaps some cache from earlier. My own PRs yesterday passed through fine. Also it is not toally clear what this brings, can you make an example script for the gallery demonstrating usage? |
I removed the specific zarr reader as it was an old file. |
Someone spotted this bracket typo in the calculation of the irradiance Boorhin/Clyde#1
I have integrated all the changes and minor bug corrections I observed
I can (in my setup) read and write CF and UGRID compliants files
The only thing that I had to modify that may have an impact is a line in base_model.py that wants to import the file before you write it really.
It is meant as a source of inspiration more than an all rounder. It considerably accelerates my usage by reading directly zarr through xarray and writing trajectory files in xarray with daskarray buffers.